-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 3.0.0 #107
Merged
Merged
Release 3.0.0 #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update generated code
Fix a bug where pin auth events would not get sent correctly
Feature/fp 34
FP-Hotfixtests hot fox for some failing android tests
This api wasn't fully implemented in iOS and is not very useful, so let's just remove it while we still can :^)
FP-62: Android: Move SSO into a useCase and add Tests
This commit updates startApp to go through pigeon, for this we need to update a few types that get passed along and need to update how we create some of the main objects on the dart side. e.g. the native interface api. It also has some changes on how we deal with the config on the Android side.
…the same time, removed unused usecase form android with isauthenticatorregistered
Update the iOS TokenServer configuration
…unauthenticated and only allowing one otp flow at the time, additionally reworked CALLBACK to callback on android, and moved the callback logic into companion object for accept- and deny-mobileauthenticationrequestusecases
FP-RENAME-PIGEON-FILES renamed pigeon files to better indicate that t…
Also attempt to cancel customRegistration during during our cancel
Biometric authenticator message
Feature/fp 87
Feature/fp 51
Error codes
It was possible to pass in an available but not registered authenticator into the authenticate_user method if biometrics were available but not registered. This would result in an error instead of fallback to pin. This commit fixes that by only checking registered authenticators when authenticating user.
PiotrKlis
approved these changes
May 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes already checked in other PRs 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.